Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events Post blocks #261

Closed
ebuchman opened this issue Jan 16, 2015 · 2 comments
Closed

Events Post blocks #261

ebuchman opened this issue Jan 16, 2015 · 2 comments

Comments

@ebuchman
Copy link
Contributor

I recall in the old ethreactor, if a channel was blocked while trying to post on it (ie. there was no receiver waiting with a <- chan), the channel would be skipped (an error message came along with this).

This no longer seems to be the behaviour. Is this intended? or should we add the

default:
  logger.Debugf("subscribing channel %d to event %s blocked. skipping\n", i, event.Name)

back to the switch statement?
@fjl
Copy link
Contributor

fjl commented Jan 16, 2015

This is intended. The idea behind this was that synchronous messaging is easier to reason about. With the current design, there are never any pending events stuck in a queue somewhere.
You can use the event system as a synchronization device. =

@fjl
Copy link
Contributor

fjl commented Jan 16, 2015

If you have a need for asynchronous posting of events use go mux.Post(...).

@fjl fjl closed this as completed Jan 16, 2015
markya0616 pushed a commit to getamis/go-ethereum that referenced this issue Jan 31, 2018
@patrickmn
Merge pull request ethereum#261 from jimthematrix/permissioned-nodes
f27f7b3 
Fixed missing DataDir value in p2p server that affected permissioned nodes
Zergity added a commit to Zergity/go-ethereum that referenced this issue Apr 28, 2020
@Zergity
Merge pull request ethereum#261 from nextyio/vdf
9358b10 
VDF pre-compiled gas requirement and go routine clean up
maoueh pushed a commit to streamingfast/go-ethereum that referenced this issue Aug 13, 2021
@tynes
config: use max possible max calldata size (ethereum#261)
b96fcee 
* config: use max possible max calldata size

* config: fix max calldata size

* config: fix max calldata size
tony-ricciardi pushed a commit to tony-ricciardi/go-ethereum that referenced this issue Jan 20, 2022
@nicholasguo
Total supply for celo gold (ethereum#261)
7b15320
maoueh pushed a commit to streamingfast/go-ethereum that referenced this issue May 3, 2022
@temaniarpit27 @ferranbt
@ssandeep @jdkanani
V0.2.12 candidate (ethereum#261)
39116e6 
* Fix ancient receipts

* bumped version to 0.2.11

* Genesis change fix (ethereum#252)

* read from genesis file

* add: set code in finalize and assemble

* new: storing data in bor config

* chg: remove unwanted code

* chg: refactor

* minor change

* add error states

* Fix small things

* Add test

* Add more coverage in genesis finalize test

* Ensure balance is not changed

* Add decode safe check

* Change bor config block alloc field name

* Remove block alloc values in blocks

* Add genesis alloc code change info logging

Co-authored-by: Ferran Borreguero <ferranbt@protonmail.com>

* add block alloc

* change block alloc

* remove byte array

* mainnet upgrade

Co-authored-by: Ferran Borreguero <ferranbt@protonmail.com>
Co-authored-by: Sandeep Sreenath <sandeep.sreenath@gmail.com>
Co-authored-by: Jaynti Kanani <jdkanani@gmail.com>
weiihann pushed a commit to weiihann/go-ethereum that referenced this issue Sep 27, 2023
@gballet
remove unused map param in MakeVerkleMultiProof (ethereum#261)
cd83a7b
sduchesneau pushed a commit to streamingfast/go-ethereum that referenced this issue Jan 4, 2024
@joshuacolvin0
Merge pull request ethereum#261 from OffchainLabs/fix-skipped-state-gc
5d9bb83 
garbage collect not commited tries
maoueh pushed a commit to streamingfast/go-ethereum that referenced this issue Apr 29, 2024
@sebastianst
Merge pull request ethereum#261 from ethereum-optimism/set-up-codeowners
ef668c7 
setting up CODEOWNERS
s1na pushed a commit to s1na/go-ethereum that referenced this issue Dec 2, 2024
@wgr523
Extend masternode candidate (ethereum#261)
cd74061 
* V2 truncate MaxMasternodes from candidates after penalty,
V1 same as before

TestUpdateMultipleMasterNodes: test V2, in snapshot we have all candidates, but at epoch switch, we pick MaxMasternodes

* code looks better
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fjl @ebuchman