Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dumpconfig doesn't work #26328

Closed
J-A-M-E-5 opened this issue Dec 8, 2022 · 2 comments
Closed

dumpconfig doesn't work #26328

J-A-M-E-5 opened this issue Dec 8, 2022 · 2 comments
Assignees
@rjl493456442
Labels
type:bug

Comments

@J-A-M-E-5
Copy link

J-A-M-E-5 commented Dec 8, 2022 •
edited
Loading

System information

Geth version: Version: 1.11.0-unstable
OS & Version: Linux
Commit hash : 6891288

Expected behaviour

$ geth --mainnet --datadir /node/geth dumpconfig

Config file dumped.

Actual behaviour

$ geth --mainnet --datadir /node/geth dumpconfig
INFO [12-08|04:21:15.611] Maximum peer count                       ETH=50 LES=0 total=50
INFO [12-08|04:21:15.615] Smartcard socket not found, disabling    err="stat /run/pcscd/pcscd.comm: no such file or directory"
INFO [12-08|04:21:15.622] Set global gas cap                       cap=50,000,000
toml: cannot marshal nil *types.Block

Returns to terminal.

Steps to reproduce the behaviour

$ geth --mainnet --datadir /node/geth dumpconfig
@rjl493456442 rjl493456442 self-assigned this Dec 8, 2022
@rjl493456442 rjl493456442 mentioned this issue Dec 8, 2022
Merged
fjl pushed a commit that referenced this issue Dec 8, 2022
@rjl493456442
eth, cmd: remove syncTarget from eth config (#26330)
890e2ef 
--syncTarget is a feature for development purpose in post-merge world. Previously
it's added into eth.Config. But it turns out that's a stupid idea.

- syncTarget is a block object, which is hard to be put in config file(large)
- syncTarget is just a dev feature, doesn't make too much sense to add it in config file

So I remove it from the eth config object. And it also fixes the #26328
@rjl493456442
Copy link
Member

It's fixed in #26330, please try the master again.

@J-A-M-E-5
Copy link
Author

It's fixed in #26330, please try the master again.

Can confirm it is now working to my expectations. Thanks all for your quick fix. 🍺

@nolanxyg nolanxyg mentioned this issue Feb 28, 2023
Closed
shekhirin pushed a commit to shekhirin/go-ethereum that referenced this issue Jun 6, 2023
@rjl493456442 @shekhirin
eth, cmd: remove syncTarget from eth config (ethereum#26330)
e4b9d7b 
--syncTarget is a feature for development purpose in post-merge world. Previously
it's added into eth.Config. But it turns out that's a stupid idea.

- syncTarget is a block object, which is hard to be put in config file(large)
- syncTarget is just a dev feature, doesn't make too much sense to add it in config file

So I remove it from the eth config object. And it also fixes the ethereum#26328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjl493456442 rjl493456442

Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rjl493456442 @J-A-M-E-5