-
Notifications
You must be signed in to change notification settings - Fork 20.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow state override on eth_estimateGas #27800
Labels
Comments
antonydenyer
changed the title
Allow state override to eth_estimateGas
Allow state override on eth_estimateGas
Jul 28, 2023
Hi @antonydenyer. I think it makes sense to add these overrides, and probably the block overrides which have recently been added to You indicated you're willing to implement this feature. I'd personally welcome your contribution and can gladly review it. |
1 task
6 tasks
github-merge-queue bot
pushed a commit
to matter-labs/zksync-era
that referenced
this issue
Jul 22, 2024
## What ❔ - Adds state override for gas estimates ## Why ❔ - Solves #947 - Feature parity with geth ethereum/go-ethereum#27800 ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. - [x] Spellcheck has been run via `zk spellcheck`. - [x] Linkcheck has been run via `zk linkcheck`. --------- Co-authored-by: Juan Rigada <62958725+Jrigada@users.noreply.github.com> Co-authored-by: Jrigada <jrigada@est.frba.utn.edu.ar> Co-authored-by: Danil <deniallugo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Rationale
Currently, you can not perform an
eth_estimateGas
on something that isn't in the 'correct' state as the evm will, correctly, return an error. For example, on an erc20 you may wish to send anapprove
followed by atransfer
call. You can estimate gas for theapprove
but not thetransfer
.Implementation
Add an additional parameter to the end of the request in the same way
eth_call
does.Are you willing to implement this feature? Yes
The text was updated successfully, but these errors were encountered: