Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: make build/goimports.sh more potable #17087

Merged
merged 1 commit into from
Jun 27, 2018
Merged

build: make build/goimports.sh more potable #17087

merged 1 commit into from
Jun 27, 2018

Conversation

hackmod
Copy link
Contributor

@hackmod hackmod commented Jun 26, 2018

  • #!/usr/bin/env bash => #!/bin/sh
  • -not => ! (posix compliant)
  • -wholename => -path

karalabe
karalabe approved these changes Jun 27, 2018
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@karalabe karalabe added this to the 1.8.12 milestone Jun 27, 2018
@karalabe karalabe merged commit e916f97 into ethereum:master Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.12
Development

Successfully merging this pull request may close these issues.
2 participants
@hackmod @karalabe