core/vm: Hide read only flag from Interpreter interface #17461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
commented
Aug 21, 2018
core/vm/interpreter.go
Outdated
| @@ -125,7 +121,7 @@ func (in *EVMInterpreter) enforceRestrictions(op OpCode, operation operation, st | |||
| // It's important to note that any errors returned by the interpreter should be | |||
| // considered a revert-and-consume-all-gas operation except for | |||
| // errExecutionReverted which means revert-and-keep-gas-left. | |||
| func (in *EVMInterpreter) Run(contract *Contract, input []byte) (ret []byte, err error) { | |||
| func (in *EVMInterpreter) Run(contract *Contract, input []byte, static bool) (ret []byte, err error) { | |||
There was a problem hiding this comment.
I forgot to rename this to readOnly.
fjl
requested changes
Sep 3, 2018
chfast
force-pushed
the
vm-static-flag
branch
from
69fc7af
to
9e839c9
Compare
|
Done. |
fjl
approved these changes
Sep 4, 2018
holiman
reviewed
Sep 4, 2018
|
I can live with this, but it forces the global |
Closed
Obviously this change is dictated by EVMC design. The EVMC tries to keep the responsibility for EVM features totally inside the VMs, if feasible. This makes VM "stateless" because VM does not need to pass any information between executions, all information is included in parameters of the execute function. So in the EVMC PR for geth this flag is never used by the EVMC VM and is also not accurate, so querying it might give wrong results. I'm not sure this provided enough arguments for it to make you feel comfortable with the change. |
chfast
force-pushed
the
vm-static-flag
branch
from
9e839c9
to
c449b5a
Compare
holiman
approved these changes
Sep 7, 2018
5chdn
added a commit
to goerli/go-ethereum-aura
that referenced
this pull request
Sep 8, 2018
…) (#6) Makes Interface interface a bit more stateless and abstract. Obviously this change is dictated by EVMC design. The EVMC tries to keep the responsibility for EVM features totally inside the VMs, if feasible. This makes VM "stateless" because VM does not need to pass any information between executions, all information is included in parameters of the execute function.
dutterbutter
pushed a commit
to goerli/go-ethereum-aura
that referenced
this pull request
Sep 8, 2018
* go modules added; preparing to write aura consensus * adding goerli flag * goerli flag added * adding configs * core/vm: Hide read only flag from Interpreter interface (ethereum#17461) (#6) Makes Interface interface a bit more stateless and abstract. Obviously this change is dictated by EVMC design. The EVMC tries to keep the responsibility for EVM features totally inside the VMs, if feasible. This makes VM "stateless" because VM does not need to pass any information between executions, all information is included in parameters of the execute function. * configuring genesis * removing duplicate imports * adding configs for aura api * configuring goerli cli flag * flag function fix * typo fix
ChainSafeSystems
pushed a commit
to goerli/go-ethereum-aura
that referenced
this pull request
Sep 8, 2018
* go modules added; preparing to write aura consensus * adding goerli flag * goerli flag added * adding configs * core/vm: Hide read only flag from Interpreter interface (ethereum#17461) (#6) Makes Interface interface a bit more stateless and abstract. Obviously this change is dictated by EVMC design. The EVMC tries to keep the responsibility for EVM features totally inside the VMs, if feasible. This makes VM "stateless" because VM does not need to pass any information between executions, all information is included in parameters of the execute function. * configuring genesis * removing duplicate imports * adding configs for aura api * configuring goerli cli flag * flag function fix * typo fix * goerli flag finalized * config mod
ChainSafeSystems
pushed a commit
to goerli/go-ethereum-aura
that referenced
this pull request
Sep 8, 2018
* go modules added; preparing to write aura consensus * adding goerli flag * goerli flag added * adding configs * core/vm: Hide read only flag from Interpreter interface (ethereum#17461) (#6) Makes Interface interface a bit more stateless and abstract. Obviously this change is dictated by EVMC design. The EVMC tries to keep the responsibility for EVM features totally inside the VMs, if feasible. This makes VM "stateless" because VM does not need to pass any information between executions, all information is included in parameters of the execute function. * configuring genesis * removing duplicate imports * adding configs for aura api * configuring goerli cli flag * flag function fix * modifying configs
thanhnguyennguyen
pushed a commit
to thanhnguyennguyen/tomochain-v1
that referenced
this pull request
Sep 29, 2019
Makes Interface interface a bit more stateless and abstract. Obviously this change is dictated by EVMC design. The EVMC tries to keep the responsibility for EVM features totally inside the VMs, if feasible. This makes VM "stateless" because VM does not need to pass any information between executions, all information is included in parameters of the execute function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not really a functional change, but makes Interface interface a bit more stateless and abstract.