Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

downloader: fix edgecase where returned index is OOB for downloader #18335

Merged
merged 2 commits into from
Dec 20, 2018
Merged

downloader: fix edgecase where returned index is OOB for downloader #18335

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8519224
downloader: fix edgecase where returned index is OOB for downloader
holiman Dec 19, 2018
9c4bf98
downloader: documentation
gballet Dec 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion eth/downloader/downloader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1488,7 +1488,11 @@ func (d *Downloader) importBlockResults(results []*fetchResult) error {
blocks[i] = types.NewBlockWithHeader(result.Header).WithBody(result.Transactions, result.Uncles)
}
if index, err := d.blockchain.InsertChain(blocks); err != nil {
log.Debug("Downloaded item processing failed", "number", results[index].Header.Number, "hash", results[index].Header.Hash(), "err", err)
if index < len(results) {
log.Debug("Downloaded item processing failed", "number", results[index].Header.Number, "hash", results[index].Header.Hash(), "err", err)
} else {
log.Debug("Downloaded item processing failed on sidechain import", "index", index, "err", err)
holiman marked this conversation as resolved.
Show resolved Hide resolved
}
return errInvalidChain
}
return nil
Expand Down