Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/compiler: fixed testSource #18978

Merged
merged 1 commit into from
Feb 3, 2019
Merged

common/compiler: fixed testSource #18978

merged 1 commit into from
Feb 3, 2019

Conversation

jasagredo
Copy link
Contributor

The test for the common/compiler package fails because the string that is fed into solc doesn't declare a solidity pragma. This declaration is needed in solc >=0.4.0.

It might be better to replace >0.0.0 for >=0.4.0.

@jasagredo
Copy link
Contributor Author

pragma solidity >0.0.0; was just to ensure it would potentially accept all solc versions.

@fjl fjl merged commit 98e0bed into ethereum:master Feb 3, 2019
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Dec 19, 2024
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Dec 21, 2024
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Dec 26, 2024
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants