Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swarm: CI race detector test adjustments #19017

Merged
merged 5 commits into from
Feb 8, 2019
Merged

swarm: CI race detector test adjustments #19017

merged 5 commits into from
Feb 8, 2019

Commits on Feb 7, 2019

  1. swarm/storage: delete unused function parameters in tests 

    'chunksize' and 'processors' were unused; I did a cascading delete.
    Ferenc Szabo committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    500a9fb View commit details
    Browse the repository at this point in the history

  2. swarm/storage: increase mput timeout for TestCleanIndex 

    The following test failed with `-race` flag on Travis.

--- FAIL: TestCleanIndex (43.85s)
    ldbstore_test.go:757: context deadline exceeded

As `-race` can increase the run time by 10x.

Alternative: we could just to increase the timeout for the
specific test. As currently the timeout is hardcoded and (strangely)
does not depend on the size of 'n'. That could be achieved by adding
a new function mputWithCustomTimeout(), but then we should keep
symmetry and add custom timeout for mget(), too. But I think the
method already has too many parameters and might be replaced by
the ongoing storage rewrite. So I won't do.
    Ferenc Szabo committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    2102dec View commit details
    Browse the repository at this point in the history

  3. swarm/network: increase timeout for TestNetworkID 

    The following test failed with `-race` flag on Travis.

--- FAIL: TestNetworkID (9.04s)
    networkid_test.go:77: Error setting up network: context deadline exceeded

As `-race` can increase the run time by 10x.
    Ferenc Szabo committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    ac41a75 View commit details
    Browse the repository at this point in the history

  4. swarm/network: decrease nodeCount for TestOverlaySim 

    TestOverlaySim consistently failed with `-race` flag on Travis. My
assumption was that we hit Travis' memory limitations. After decreasing
the node count the test started to pass.

Note: `-race` may increase memory usage by 5-10x

=== RUN   TestOverlaySim
panic: Could not startup node network for mocker

goroutine 35 [running]:
github.com/ethereum/go-ethereum/p2p/simulations.startStop(0xc0002a7000, 0xc0002a8b40, 0x10)
	/home/travis/gopath/src/github.com/ethereum/go-ethereum/p2p/simulations/mocker.go:66 +0x8a0
created by github.com/ethereum/go-ethereum/p2p/simulations.(*Server).StartMocker
	/home/travis/gopath/src/github.com/ethereum/go-ethereum/p2p/simulations/http.go:348 +0x260
FAIL	github.com/ethereum/go-ethereum/swarm/network/simulations	2.788s
    Ferenc Szabo committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    baff204 View commit details
    Browse the repository at this point in the history

  5. swarm/network: increase context timeout for TestFileRetrieval 

    The following test failed with `-race` flag on Travis. As `-race` might
increase the execution time by 2-20x.

--- FAIL: TestFileRetrieval (62.45s)
    snapshot_retrieval_test.go:61: context deadline exceeded
FAIL	github.com/ethereum/go-ethereum/swarm/network/stream	240.794s
    Ferenc Szabo committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    64372e0 View commit details
    Browse the repository at this point in the history