Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Go 1.12 #19166

Merged
merged 2 commits into from
Feb 27, 2019
Merged

Upgrade to Go 1.12 #19166

merged 2 commits into from
Feb 27, 2019

Conversation

SamuelMarks
Copy link
Contributor

@SamuelMarks SamuelMarks changed the title [.travis.yml,appveyor.yml,docstring] Upgrade to Go 1.12 Upgrade to Go 1.12 Feb 26, 2019
karalabe
karalabe approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe added this to the 1.9.0 milestone Feb 26, 2019
@karalabe
Copy link
Member

I've worked around one upstream bug: golang/go#30399

Still fails with another upstream issue: golang/go#30401

@mvdan
Copy link

mvdan commented Feb 26, 2019

FWIW, a cleaner way to work around the vet issue in 1.12 is to add something like:

import (
    _ "fmt" // TODO: remove once https://github.com/golang/go/issues/30399 is fixed
)

@karalabe
Copy link
Member

@mvdan Yeah, but since the issue is only in some relatively tiny test code, might as well just replace that formatting string. It's not something essential or live either way.

@karalabe karalabe merged commit 505a49e into ethereum:master Feb 27, 2019
@SamuelMarks SamuelMarks deleted the go-1.12 branch April 6, 2019 02:17
@prd-fox prd-fox mentioned this pull request Nov 25, 2019
Merged
@gzliudan gzliudan mentioned this pull request Jul 10, 2024
Merged
19 tasks
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jul 11, 2024
@gzliudan
common/fdlimit: fix macos file descriptors for Go 1.12 (ethereum#19166)
2bfff1e
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jul 17, 2024
@gzliudan
common/fdlimit: fix macos file descriptors for Go 1.12 (ethereum#19166)
cef61d4
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jul 18, 2024
@gzliudan
common/fdlimit: fix macos file descriptors for Go 1.12 (ethereum#19166)
8a1fd13
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jul 26, 2024
@gzliudan
common/fdlimit: fix macos file descriptors for Go 1.12 (ethereum#19166)
c51fcb5
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jul 29, 2024
@gzliudan
common/fdlimit: fix macos file descriptors for Go 1.12 (ethereum#19166)
ecb31f7
gzliudan added a commit to XinFinOrg/XDPoSChain that referenced this pull request Aug 3, 2024
@gzliudan
common/fdlimit: fix macos file descriptors for Go 1.12 (ethereum#19166)
4671262
gzliudan added a commit to XinFinOrg/XDPoSChain that referenced this pull request Aug 19, 2024
@gzliudan
common/fdlimit: fix macos file descriptors for Go 1.12 (ethereum#19166)
f5e8fbc
wanwiset25 pushed a commit to XinFinOrg/XDPoSChain that referenced this pull request Aug 23, 2024
@gzliudan @wanwiset25
common/fdlimit: fix macos file descriptors for Go 1.12 (ethereum#19166)
37fd4dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe approved these changes

@holiman holiman Awaiting requested review from holiman holiman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SamuelMarks @karalabe @mvdan