core/*: Encapsulate blockchain data storage #19200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matthalp-zz
requested review from
holiman,
karalabe and
zsfelfoldi
as code owners
Matthalp-zz
force-pushed
the
core-chaindb-for-headerchain-and-above
branch
3 times, most recently
from
3c6099f to
a3cc9cd
Compare
This introduces a blockchain data storage package, `chaindb`. `chaindb.ChainDB` serves as a layer between the blockchain (and headerchain and lightchain) and the underlying key-value storage. It can be best thought of as the blockchain data counterpart to `core/state/statedb` and ultimately a replacement for `rawdb`*, whose code would be moved where it is currently being called within `chaindb.ChainDB` whose use is a 1:1 mapping from before.** The goals of this work are twofold: 1. Consolidate code interacting with storage. 2. With (1) in place continue the freezer work initiated ethereum#17814 inside. Follow up work from this PR would be: 1. Use `chaindb.ChainDB` in the remaining places where `rawdb` is being used. 2. Migrate the various caches used between `ethdb.Database` inside the storage and also expose tuning options to set them. 3. Continue with the freezer work. This also introduces the `github.com/google/go-cmp/cmp/cmpopts` package, which is used for the tests added for this work. * The only exception is `WritePreimages` which is really a `StateDB` concept, however it is included as it is currently stored/retrieved through methods in `rawdb`. ** The only exception is `WriteCanonicalHash` whose method parameter order was swapped as the `number` is the key and the `hash` is the value being mapped to it, making it consistent with the "key" then "value" convention the remaining methods use.
Matthalp-zz
force-pushed
the
core-chaindb-for-headerchain-and-above
branch
from
a3cc9cd to
3cf22e7
Compare
This was referenced Mar 3, 2019
cmingxu
reviewed
Mar 12, 2019
| return rawdb.ReadCanonicalHash(c.db, number) | ||
| } | ||
|
|
||
| // WriteCanonicalHash stores the canoical hash assigned to a block number. |
There was a problem hiding this comment.
canoical => canonical, typo
|
This PR came at a time when we were doing major internal refactorings (e.g. ancients), and has thus at this point in time become very hard to apply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a blockchain data storage package,
chaindb.chaindb.ChainDBserves as a layer between the blockchain (and headerchain and lightchain) and
the underlying key-value storage. It can be best thought of as the blockchain
data counterpart to
core/state/statedband ultimately a replacement forrawdb[1], whose code would be moved where it is currently being called withinchaindb.ChainDBwhose use is a 1:1 mapping from before [2]The goals of this work are twofold:
Follow up work from this PR would be:
chaindb.ChainDBin the remaining places whererawdbis being used.ethdb.Databaseinside the storageand also expose tuning options to set them.
This also introduces the
github.com/google/go-cmp/cmp/cmpoptspackage,which is used for the tests added for this work.
[1] The only exception is
WritePreimageswhich is really aStateDBconcept, however it is included as it is currently stored/retrieved
through methods in
rawdb.[2] The only exception is
WriteCanonicalHashwhose method parameter orderwas swapped as the
numberis the key and thehashis the value beingmapped to it, making it consistent with the "key" then "value" convention
the remaining methods use.