Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/state/snapshot: make difflayer account iterator seek operation inclusive #20953

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Apr 21, 2020

This PR fixes an issue in the account iterator for difflayers (disk layers are correct).
A seek operation to 0x00.. would never return a theoretical key at that location, so the seek op must be inclusive, not exclusive.

Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@karalabe karalabe added this to the 1.9.14 milestone Apr 22, 2020
@karalabe karalabe merged commit 870d4c4 into ethereum:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants