core/state/snapshot: fix journal nil deserialziation #21003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The snapshot journal uses RLP to serialize the in-memory diff layers on shutdown/restart. An RLP serialize and deserialize round however loses the nil-ness of a byte slice, converting it to empty: https://play.golang.org/p/bAxBMJrryYz
This PR converts the empty slices back to nil, since the snapshotter depends on nils explicitly. It is fine to do this because an "empty" account rlp blob makes no sense, and empty values are not stored in storage tries either.