-
Notifications
You must be signed in to change notification settings - Fork 20.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/vm: fast push/pop/swap/dup #21193
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Master:
This PR:
|
holiman
force-pushed
the
fixedbig_optimizations
branch
from
June 8, 2020 18:06
7f0b395
to
9a19928
Compare
Update with
|
holiman
force-pushed
the
fixedbig_optimizations
branch
2 times, most recently
from
June 10, 2020 09:08
ecd9c58
to
11f707f
Compare
Thiis now on benchmarker: https://geth-bench.ethdevops.io/d/Jpk-Be5Wk/dual-geth?orgId=1&var-exp=bench03&var-master=bench04&var-percentile=50&from=1591781494201&to=now&refresh=5s
|
Against non-uint256 master branch: name old time/op new time/op delta SwapDupLoop-6 65.6ms ± 5% 58.0ms ± 5% -11.60% (p=0.000 n=10+10) name old alloc/op new alloc/op delta SwapDupLoop-6 48.5kB ± 0% 42.5kB ± 0% -12.36% (p=0.000 n=9+10) name old allocs/op new allocs/op delta SwapDupLoop-6 69.0 ± 0% 70.5 ± 1% +2.17% (p=0.000 n=9+10)
name old time/op new time/op delta PushPopLoop-6 80.5ms ± 7% 75.1ms ± 2% -6.74% (p=0.000 n=10+9)
holiman
force-pushed
the
fixedbig_optimizations
branch
from
July 20, 2020 09:19
11f707f
to
92b5f20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.
This PR breaks consensus theoretically, because if there's a push outside the range of the code, we just push a zero on the stack. In practice, that's fine, because execution will stop at that point anyway.
There's something odd happening. I'm not getting any test failures, but
The gas used is funky. I think it may be because the
bench
flag makes the execution reuse the same state, and does not reset it between runs. So if the bench is invoked several times, it can report different values.Some synthetic benchmarks: