Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethclient: add GetProof method #21753

Closed
wants to merge 1 commit into from
Closed

ethclient: add GetProof method #21753

wants to merge 1 commit into from

Conversation

p4u
Copy link
Contributor

@p4u p4u commented Oct 25, 2020

Exposes EIP 1186 eth_getProof method to ethclient ethereum/EIPs#1186

@MariusVanDerWijden
Copy link
Member

Rel: #21738
Imo instead of adding this to the ethclient we should create a seperate interface for all geth specific methods

@p4u
Copy link
Contributor Author

p4u commented Oct 25, 2020

Yeah, that makes sense. However it would require a refactor and a big effort. I'd suggest to incorporate mean-while this implementation or else we could return a byte array from json.Marshal() in order to keep the caller away from the internal ethapi.AccountResult type

@fjl
Copy link
Contributor

fjl commented Nov 2, 2020

I don't want to add a temp workaround. The refactoring is not that large, we just need someone to get this gethclient package started and add the one method they want. @fxfactorial already offered to do it in #21738 in order to get a wrapper for the eth_call with overrides. Once that's in, we can add GetProof as well.

@p4u
Copy link
Contributor Author

p4u commented Nov 2, 2020

fine, thanks.

@p4u p4u closed this Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants