Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accounts, signer: fix Ledger Live account derivation path (clef) #21757

Merged
merged 4 commits into from
Nov 29, 2020
Merged

accounts, signer: fix Ledger Live account derivation path (clef) #21757

merged 4 commits into from
Nov 29, 2020

Commits on Nov 2, 2020

  1. signer/core/api: fix derivation of ledger live accounts 

    For ledger hardware wallets, change account iteration as follows:

- ledger legacy: m/44'/60'/0'/X; for 0<=X<5
- ledger live: m/44'/60'/0'/0/X; for 0<=X<5

- ledger legacy: m/44'/60'/0'/X; for 0<=X<10
- ledger live: m/44'/60'/X'/0/0; for 0<=X<10

Non-ledger derivation is unchanged and remains as:
- non-ledger: m/44'/60'/0'/0/X; for 0<=X<10
    @svenski123
    svenski123 committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    213d80e View commit details
    Browse the repository at this point in the history

  2. signer/core/api: derive ten default paths for all hardware wallets, p… 

    …lus ten legacy and ten live paths for ledger wallets
    @svenski123
    svenski123 committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    b719dbe View commit details
    Browse the repository at this point in the history

  3. signer/core/api: as .../0'/0/0 already included by default paths, do … 

    …not include it again with ledger live paths
    @svenski123
    svenski123 committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    d23a7d4 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2020

  1. accounts, signer: implement path iterators for hd wallets

    @holiman
    holiman committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    7b315a3 View commit details
    Browse the repository at this point in the history