les: use eth64 instead of 63 #21980
Closed
les: use eth64 instead of 63 #21980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
... actually, I guess we should just use |
rjl493456442
approved these changes
Dec 9, 2020
|
This fix is moot -- it's what the les server registers it's light-peers with in the downloader. So what matters is only that we're internally consistent, it doesn't matter what the remote client peer actually sends. So as long as we fix this in #21482 , that's fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're dropping support for
63with 1.10, so would be good to have this in for the upcoming release