Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consensus: refactor FinalizeAndAssemble to use Finalize #21993

Merged
merged 1 commit into from
Dec 11, 2020
Merged

consensus: refactor FinalizeAndAssemble to use Finalize #21993

merged 1 commit into from
Dec 11, 2020

Conversation

Mr-Leshiy
Copy link
Contributor

Small refactor of the FinalizeAndAssemble function in both consensus engines.

@Mr-Leshiy Mr-Leshiy marked this pull request as ready for review December 11, 2020 09:19
holiman
holiman approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@holiman holiman changed the title Small refactor FinalizeAndAssemble function consensus: refactor FinalizeAndAssemble to use Finalize Dec 11, 2020
@Mr-Leshiy
Copy link
Contributor Author

@holiman , Does I have to fix an issue with the CI? The problem is with the one test of the ethash, but I cant reproduce it locally.

@holiman
Copy link
Contributor

holiman commented Dec 11, 2020

No, you don't have to worry about that, the CI is a bit flaky is all

@holiman holiman added this to the 1.10.0 milestone Dec 11, 2020
@holiman holiman merged commit c49aae9 into ethereum:master Dec 11, 2020
@Mr-Leshiy Mr-Leshiy deleted the feature/refactor_FinalizeAndAssemble branch December 14, 2020 15:17
@quorumbot quorumbot mentioned this pull request Sep 3, 2021
Merged
9 tasks
@baptiste-b-pegasys baptiste-b-pegasys mentioned this pull request Sep 3, 2021
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Mr-Leshiy @holiman