Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth, core: speed up some tests #22000

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Dec 11, 2020

eth tests on appveyor were 52s before this PR, bloombits at 13s. Let's see what they land on with this PR -- it's definitely much faster on my machine

eth/handler_test.go Outdated Show resolved Hide resolved
@holiman
Copy link
Contributor Author

holiman commented Dec 11, 2020

Timewise, it shaves off at least something

ok  	github.com/ethereum/go-ethereum/eth	41.743s	coverage: 33.7% of statements
ok  	github.com/ethereum/go-ethereum/core/bloombits	6.919s	coverage: 96.2% of statements

@holiman
Copy link
Contributor Author

holiman commented Dec 11, 2020

(note to self: on hold until after #21482 )

Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants