Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: upgrade to golang-lru v0.5.5 #22134

Merged
merged 1 commit into from
Jan 20, 2021
Merged

go.mod: upgrade to golang-lru v0.5.5 #22134

merged 1 commit into from
Jan 20, 2021

Conversation

ucwong
Copy link
Contributor

@ucwong ucwong commented Jan 7, 2021

@holiman
Copy link
Contributor

holiman commented Jan 12, 2021

LGTM, but the change is only 8 days old, and not yet in an official release, so I'd rather wait a bit longer to see if it's stable. We haven't been bit by that deadlock yet, afaik, so it's probably not critical enough for us to insta-upgrade

@fjl fjl changed the title golang-lru possible deadlock fix go.mod: upgrade to golang-lru v0.5.5 Jan 19, 2021
@fjl fjl removed the status:triage label Jan 19, 2021
@fjl
Copy link
Contributor

fjl commented Jan 19, 2021

This needs a rebase. The commit that's being updated to fixes an issue with the eviction callback, which we don't use in go-ethereum. So it's not that important for us to upgrade this dependency.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@holiman holiman merged commit 7da8f75 into ethereum:master Jan 20, 2021
@holiman holiman added this to the 1.10.0 milestone Jan 20, 2021
bulgakovk pushed a commit to bulgakovk/go-ethereum that referenced this pull request Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants