accounts/scwallet: use go-ethereum crypto instead of go-ecdh #22212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
reviewed
Jan 22, 2021
gballet
requested changes
Jan 26, 2021
There was a problem hiding this comment.
This breaks the establishment of the secure channel between geth and the smartcard.
err="failed to authenticate card 0421b855: unexpected insecure response status Cla=0x80, Ins=0x11, Sw=0x6982"
It still works in master. I assume this is just a difference of format, I'll keep investigating.
|
That's the exception being raised https://www.win.tue.nl/pinpasjc/docs/apis/jc222/javacard/framework/ISO7816.html#SW_SECURITY_STATUS_NOT_SATISFIED |
gballet
approved these changes
Jan 26, 2021
github.com/wsddn/go-ecdh is a wrapper package for ECDH functionality with any elliptic curve. Since 'generic' ECDH is not required in accounts/scwallet (the curve is always secp256k1), we can just use the standard library functionality and our own crypto libraries to perform ECDH and save a dependency.
Co-authored-by: Guillaume Ballet <gballet@gmail.com>
gballet
force-pushed
the
scwallet-standalone
branch
from
f75be49
to
4114408
Compare
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.com/wsddn/go-ecdh is a wrapper package for ECDH with any elliptic curve.
Since 'generic' ECDH is not required in accounts/scwallet (the curve is always secp256k1),
we can just use the standard library and our own crypto libraries to perform
ECDH and save a dependency.