Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accounts/abi/bind: fixed unpacking error #22230

Merged

Conversation

MariusVanDerWijden
Copy link
Member

There was a dormant error with structured inputs that failed unpacking.
This commit fixes the error by switching from regular casting to the better abi.ConvertType function.
It also adds a test for calling a view function that returns a struct

closes #22219

There was a dormant error with structured inputs that failed unpacking.
This commit fixes the error by switching casting to the better abi.ConvertType function.
It also adds a test for calling a view function that returns a struct
Copy link
Member

@gballet gballet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gballet gballet added this to the 1.10.0 milestone Feb 10, 2021
@gballet gballet merged commit cb3c7e4 into ethereum:master Feb 10, 2021
renaynay pushed a commit to renaynay/go-ethereum that referenced this pull request Feb 16, 2021
There was a dormant error with structured inputs that failed unpacking.
This commit fixes the error by switching casting to the better abi.ConvertType function.
It also adds a test for calling a view function that returns a struct
filipescuc pushed a commit to EthereumGenesys/go-ethereum that referenced this pull request Mar 2, 2021
There was a dormant error with structured inputs that failed unpacking.
This commit fixes the error by switching casting to the better abi.ConvertType function.
It also adds a test for calling a view function that returns a struct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abigen v1.9.25 bytes32 interface conversion bug
2 participants