eth/tracer: extend call tracer #22245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
holiman
reviewed
Apr 20, 2021
Comment on lines
+735
to
+769
| var traceConfig *TraceConfig | ||
| if config != nil { |
There was a problem hiding this comment.
I had to think a while to figure out why this is needed. So essentially, you do this to clear out the StateOverrides, so it doesn't get applied a second time later on?
If that's the case, why not just set it to nil?
There was a problem hiding this comment.
Because api.traceTx only accepts the TraceConfig, while TraceCall use the TraceCallConfig. Here just do the parameter conversion.
holiman
approved these changes
Apr 20, 2021
eth/tracers: fix testing eth, internal: add tests internal: fix imports eth/traces: handle invalid block parameter eth/tracers: fix json field conflict
rjl493456442
force-pushed
the
extend-call-tracer
branch
from
2d2e3f3
to
938da9d
Compare
|
Rebased the PR |
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
Adds an an optional parameter `overrides *map[common.Address]account` to the `eth_call` API in order for the caller to can customize the state.
9 tasks
9 tasks
9 tasks
This was referenced Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for state overrides when tracing calls.
Fixes #22197
TODO