core: properly reset the statedb on sethead #22247
Merged
+30
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariusVanDerWijden
requested review from
holiman,
karalabe and
rjl493456442
as code owners
holiman
reviewed
Feb 1, 2021
There was a problem hiding this comment.
Semantically, this totally LGTM, and it's correct.
However, it would be totally possible to rewrite this a bit, so that instead of updating the things inside of the nested clause, you reorder the clauses a bit so that this case can just fall through. That way we don't need to increase the code size, and you would also get that pool fork update fixed.
holiman
reviewed
Feb 2, 2021
9 tasks
9 tasks
This was referenced Sep 23, 2022
|
I think part of this issue is unresolved: |
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
May 14, 2024
fixes an issue where local transactions that were included in the chain before a SetHead were rejected if resubmitted, since the txpool had not reset the state to the current (older) state.
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes an issue where local transactions that were included in the chain before a
SetHeadcould not be replayed since the txpool still had the old statedb after thesetHeadand would reject them withnonce to low.For a repro see the linked issue
resolves: #19346