Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cpu_syscall.go #22262

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Update cpu_syscall.go #22262

merged 1 commit into from
Feb 8, 2021

Conversation

isdyaufh8o7cq
Copy link
Contributor

MINOR ERROR with go1.15: src/github.com/ethereum/go-ethereum/metrics/cpu_syscall.go:34:47: invalid operation: (usage.Utime.Sec + usage.Stime.Sec) * 100 + int64(usage.Utime.Usec + usage.Stime.Usec) / 10000 (mismatched types int32 and int64)

ERROR REMEDY: src/github.com/ethereum/go-ethereum/metrics/cpu_syscall.go:34:47: invalid operation: (usage.Utime.Sec + usage.Stime.Sec) * 100 + int64(usage.Utime.Usec + usage.Stime.Usec) / 10000 (mismatched types int32 and int64)
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, reverts a regression introduced in #21921

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@holiman holiman merged commit 477fd42 into ethereum:master Feb 8, 2021
@holiman holiman added this to the 1.10.0 milestone Feb 8, 2021
renaynay pushed a commit to renaynay/go-ethereum that referenced this pull request Feb 9, 2021
fixes an regression which caused build failure on certain platforms
renaynay pushed a commit to renaynay/go-ethereum that referenced this pull request Feb 16, 2021
fixes an regression which caused build failure on certain platforms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build problem: "metrics/cpu_syscall.go:34:47: invalid operation:" int32 mixed with int64
3 participants