cmd/devp2p: fix documentation for eth-test #22298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
reviewed
Feb 10, 2021
cmd/devp2p/README.md
Outdated
| @@ -96,7 +96,7 @@ geth --datadir <datadir> --nodiscover --nat=none --networkid 19763 --verbosity 5 | |||
|
|
|||
| Then, run the following command, replacing `<enode ID>` with the enode of the geth node: | |||
There was a problem hiding this comment.
Can we call it <enode> instead of <enode ID>?
| @@ -96,7 +96,7 @@ geth --datadir <datadir> --nodiscover --nat=none --networkid 19763 --verbosity 5 | |||
|
|
|||
| Then, run the following command, replacing `<enode ID>` with the enode of the geth node: | |||
| ``` | |||
| devp2p rlpx eth-test <enode ID> cmd/devp2p/internal/ethtest/testdata/fullchain.rlp cmd/devp2p/internal/ethtest/testdata/genesis.json | |||
| devp2p rlpx eth-test <enode ID> cmd/devp2p/internal/ethtest/testdata/chain.rlp cmd/devp2p/internal/ethtest/testdata/genesis.json | |||
| ``` | |||
There was a problem hiding this comment.
Would be nice to have a sentence here that says the node needs to be reset to the initial state before running the test again.
fjl
approved these changes
Feb 11, 2021
renaynay
added a commit
to renaynay/go-ethereum
that referenced
this pull request
Feb 16, 2021
filipescuc
pushed a commit
to EthereumGenesys/go-ethereum
that referenced
this pull request
Mar 2, 2021
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the documentation for the eth test suite, as the
fullchain.rlpfile is now namedchain.rlp.