Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abi/bind: add an option to dry run a transaction #22446

Merged
merged 3 commits into from
Mar 19, 2021
Merged

abi/bind: add an option to dry run a transaction #22446

merged 3 commits into from
Mar 19, 2021

Conversation

reds
Copy link
Contributor

@reds reds commented Mar 6, 2021

Adding the DryRun option to bind.TransactOpts will cause transact to return before sending the transaction. Allows checking signatures and cost.

@fjl
Copy link
Contributor

fjl commented Mar 9, 2021

The feature is very nice, but the field needs a better name. Suggestion: NoSend.

@karalabe karalabe added this to the 1.10.2 milestone Mar 9, 2021
@reds
abi/bind: add an option to dry run a transaction
6cace71 
change option name: DryRun -> NoSend, a better description
@reds
Copy link
Contributor Author

reds commented Mar 9, 2021

Yep, NoSend describes the option much better, thanks.

MariusVanDerWijden
MariusVanDerWijden approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fjl fjl merged commit 38ea7f2 into ethereum:master Mar 19, 2021
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
@reds @atif-konasl
accounts/abi/bind: add NoSend transact option (ethereum#22446)
76f0fdd 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
@quorumbot quorumbot mentioned this pull request Apr 28, 2022
Merged
9 tasks
This was referenced Sep 23, 2022
Closed
Merged
@gzliudan gzliudan mentioned this pull request May 30, 2024
Open
19 tasks
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jul 5, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
1fa7e58 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jul 26, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
108a675 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 1, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
cbd4e5b 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 11, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
affe876 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
ff97d7d 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
664d940 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
dc3c2e9 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
39f7b52 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
dbcc162 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 19, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
7d0c6fc 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 21, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
8bf8513 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 22, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
67058d8 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 23, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
5418844 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 24, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
e694807 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 25, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
80b4f75 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 25, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
457028c 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
1959425 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
87f6490 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
b778582 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 2, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
6668a54 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 6, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
c97ea29 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
3462cb5 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
36adfab 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
689f6e7 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
7e5b360 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
f18e2fd 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
c3a4905 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
9d856fb 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@reds @gzliudan
accounts/abi/bind: add NoSend transact option (ethereum#22446)
6e7cb9d 
This adds a new option to avoid sending the transaction which is
created by calling a bound contract method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariusVanDerWijden MariusVanDerWijden MariusVanDerWijden approved these changes

@gballet gballet Awaiting requested review from gballet gballet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.2
Development

Successfully merging this pull request may close these issues.
5 participants
@reds @fjl @MariusVanDerWijden @karalabe @gballet