Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p/dnsdisc: rate limit resolving before checking cache #22566

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Mar 24, 2021

This makes the resolver rate limit apply regardless of whether the record is already
cached. It helps avoid hot-spinning in pathological cases like:

it, _ := client.NewIterator(...)
it = enode.Filter(it, func(*enode.Node) bool { return false })
for it.Next() {}

Fixes #22509

This makes the rate limit apply regardless of whether the node is
already cached.
@fjl fjl requested a review from zsfelfoldi as a code owner March 24, 2021 11:38
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe added this to the 1.10.2 milestone Mar 24, 2021
@karalabe karalabe merged commit ab8fd4d into ethereum:master Mar 24, 2021
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
This makes the rate limit apply regardless of whether the node is
already cached.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LES client consumes 100% of a CPU core when DNS discovery enabled
4 participants