log: fix formatting of big.Int #22679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of formatLogfmtBigInt had two issues: it crashed when the number was actually large enough to hit the big integer case, and modified the big.Int while formatting it.
|
Huh, I may have modified the code later. I did try those paths. |
karalabe
reviewed
Apr 16, 2021
log/format.go
Outdated
| text := n.String() | ||
| buf := make([]byte, 0, len(text)+len(text)/3) | ||
| comma := 0 | ||
| for _, c := range text { |
There was a problem hiding this comment.
You need to construct it backwards, otherwise you don't know where the commas need to be
=== RUN TestPrettyBigInt
format_test.go:76: invalid output 111,222,333,444,555,678,999,00, want 11,122,233,344,455,567,899,900
format_test.go:76: invalid output -111,222,333,444,555,678,999,00, want -11,122,233,344,455,567,899,900
karalabe
reviewed
Apr 16, 2021
| s string | ||
| }{ | ||
| {"111222333444555678999", "111,222,333,444,555,678,999"}, | ||
| {"-111222333444555678999", "-111,222,333,444,555,678,999"}, |
There was a problem hiding this comment.
If you add
{"11122233344455567899900", "11,122,233,344,455,567,899,900"},
{"-11122233344455567899900", "-11,122,233,344,455,567,899,900"},
the test will fail
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
* log: fix formatting of big.Int The implementation of formatLogfmtBigInt had two issues: it crashed when the number was actually large enough to hit the big integer case, and modified the big.Int while formatting it. * log: don't call FormatLogfmtInt64 for int16 * log: separate from decimals back, not front Co-authored-by: Péter Szilágyi <peterke@gmail.com>
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of formatLogfmtBigInt had two issues: it crashed when
the number was actually large enough to hit the big integer case, and
modified the big.Int while formatting it.