Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/utils: don't crash on nonexistent datadir #22738

Merged
merged 1 commit into from
May 3, 2021

Conversation

MariusVanDerWijden
Copy link
Member

closes #22720

Problem is that if the datadir is opened read only and does not exist, the leveldb.New command will fail.
Previous behavior was to create the datadir if non-existent.
This PR restores previous behavior

Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should figure out a better way to handle it. But the temporary fix is also good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using geth with the flags --dev and --datadir leads to an error since v1.10.2
3 participants