Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/rawdb: table compaction doesn't handle the prefix #22911

Merged
merged 1 commit into from
May 21, 2021
Merged

core/rawdb: table compaction doesn't handle the prefix #22911

merged 1 commit into from
May 21, 2021

Conversation

Evolution404
Copy link
Contributor

This function may forget to handle the prefix when the start and limit are not nil

rjl493456442
rjl493456442 approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching it, LTGM!

@rjl493456442 rjl493456442 added this to the 1.10.4 milestone May 21, 2021
@fjl fjl merged commit 81662fe into ethereum:master May 21, 2021
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
@Evolution404 @atif-konasl
core/rawdb: handle prefix in table.compact method (ethereum#22911)
66552e3
This was referenced Sep 23, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjl493456442 rjl493456442 rjl493456442 approved these changes

@holiman holiman Awaiting requested review from holiman holiman is a code owner

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@Evolution404 @rjl493456442 @fjl