-
Notifications
You must be signed in to change notification settings - Fork 20.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: add new eip-1559 tx constraints #22970
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I pushed some minor changes, reducing the bigints in buygas, and making the big number exactly on the bitlength boundary.
Please merge it if you have the necessary rights, I can't do that because of a random travis failure. |
Odd, |
I had forgotten to push some of my changes. I squashed it into the last commit, ptal @zsfelfoldi |
With these new rules in place, testing on
Which seems correct |
This PR adds the new consensus constraints of EIP-1559 transactions as specified in https://github.com/ethereum/EIPs#3594
This PR adds the new consensus constraints of EIP-1559 transactions as specified here:
ethereum/EIPs#3594
Note: the same sanity checks are performed first during tx pool validation even though the previously existing filters would filter out the same transactions. This way the same error types can be returned by the pool and by consensus.