-
Notifications
You must be signed in to change notification settings - Fork 20.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accounts/abi/bind: fix bounded contracts and sim backend for 1559 #23038
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
GasTipCap: opts.GasTipCap, | ||
Gas: gasLimit, | ||
Value: value, | ||
Data: input, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we create and add an accesslist here?
// User specified the legacy gas field, convert to 1559 gas typing | ||
call.GasFeeCap, call.GasTipCap = call.GasPrice, call.GasPrice | ||
} else { | ||
// User specified 1559 gas feilds (or none), use those |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*fields
…hereum#23038) * accounts/abi/bind: fix bounded contracts and sim backend for 1559 * accounts/abi/bind, ethclient: don't rely on chain config for gas prices * all: enable London for all internal tests * les: get receipt type info in les tests * les: fix weird test Co-authored-by: Martin Holst Swende <martin@swende.se>
This PR fixes up the simulated backend and the bound contracts to support 1559 gas price shuffling.