core,eth: avoid unnecessary receipt processing for log filtering #23058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
reviewed
Jun 21, 2021
s1na
commented
Jun 22, 2021
| logs := make([][]*types.Log, len(receipts)) | ||
| for i, receipt := range receipts { | ||
| logs[i] = receipt.Logs | ||
| logs := rawdb.ReadLogs(db, hash, *number) |
There was a problem hiding this comment.
@holiman Changed the backend's GetLogs here to utilize the new methods. GetLogs is in turn called by Filter.checkMatches
Co-authored-by: Martin Holst Swende <martin@swende.se>
Co-authored-by: Martin Holst Swende <martin@swende.se>
holiman
reviewed
Jun 22, 2021
| // ReadLogs retrieves the logs for all transactions in a block. The log fields | ||
| // are populated with metadata. In case the receipts or the block body | ||
| // are not found, a nil is returned. | ||
| func ReadLogs(db ethdb.Reader, hash common.Hash, number uint64) [][]*types.Log { |
There was a problem hiding this comment.
Triage discussion, something like
Suggested change
| func ReadLogs(db ethdb.Reader, hash common.Hash, number uint64) [][]*types.Log { | |
| type LogFilterFn func(receipts []*types.ReceiptLogs) bool | |
| func ReadLogs(db ethdb.Reader, hash common.Hash, number uint64, filterFn LogFilterFn) [][]*types.Log { |
If the filter function returns false, we can omit the ReadBody and deriving the fields.
This was referenced Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When filtering logs, after a matching block has been found a slim version of the receipts is fetched from the database. These slim receipts have to be processed to fill in some metadata. Specifically a bloom filter has to be created which adds some unnecessary overhead because this bloom is not used for filtering purposes.
In this PR we add some new methods that only try to process the underlying logs of a receipt and not much more. Note that this also means we lose the ability to cache the receipts in Blockchain.
In a very simple test (fetching
Transferevents of an erc20 token for a few thousand blocks) the runtime went from ~12s to ~7s on my machine.