Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accounts/abi/bind: call ensureContext on every context #23062

Merged
merged 1 commit into from
Jun 22, 2021
Merged

accounts/abi/bind: call ensureContext on every context #23062

merged 1 commit into from
Jun 22, 2021

Conversation

nfeignon
Copy link
Contributor

ensureContext was called for every other context in the transact method.
Without it, net/http fails with an error net/http: nil Context if the user does not provide a context.

karalabe
karalabe approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@karalabe karalabe added this to the 1.10.5 milestone Jun 22, 2021
@karalabe karalabe merged commit fcd7bdc into ethereum:master Jun 22, 2021
@gballet gballet mentioned this pull request Jun 22, 2021
Merged
@nfeignon nfeignon deleted the fix-abi-bind-ensure-context branch June 25, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe approved these changes

@gballet gballet Awaiting requested review from gballet gballet is a code owner

@MariusVanDerWijden MariusVanDerWijden Awaiting requested review from MariusVanDerWijden MariusVanDerWijden is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.5
Development

Successfully merging this pull request may close these issues.
2 participants
@nfeignon @karalabe