Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accounts/abi/bind: fix gas price suggestion with pre EIP-1559 clients #23102

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

dahu33
Copy link
Contributor

@dahu33 dahu33 commented Jun 24, 2021

I believe this PR fix a bug that prevents gas price suggestion with go-ethereum 1.10.4 and a pre EIP-1559 client (e.g. geth < v1.10.4). Thanks!

Copy link
Contributor

@fjl fjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@fjl fjl added london and removed status:triage labels Jun 29, 2021
@fjl fjl added this to the 1.10.5 milestone Jun 29, 2021
@fjl fjl merged commit 61f4b5a into ethereum:master Jun 29, 2021
sidhujag pushed a commit to sidhujag/go-ethereum that referenced this pull request Jun 30, 2021
…ethereum#23102)

This fixes transaction sending in the case where an app using go-ethereum v1.10.4
is talking to a pre-EIP-1559 RPC node. In this case, the eth_maxPriorityFeePerGas
endpoint is not available and we can only rely on eth_gasPrice.
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
…ethereum#23102)

This fixes transaction sending in the case where an app using go-ethereum v1.10.4
is talking to a pre-EIP-1559 RPC node. In this case, the eth_maxPriorityFeePerGas
endpoint is not available and we can only rely on eth_gasPrice.
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jul 5, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 1, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 2, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 6, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants