cmd/geth: don't fail on deprecated toml config fields #23118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
reviewed
Jun 28, 2021
cmd/geth/config.go
Outdated
| @@ -54,6 +55,9 @@ var ( | |||
| } | |||
| ) | |||
|
|
|||
| var empty = struct{}{} | |||
| var deprecatedConfig map[string]struct{} = map[string]struct{}{} | |||
There was a problem hiding this comment.
Another way where it doesn't just clutter the global scope would be to encapsulate in a function:
func deprecated(field string) bool{
switch(field){
case "foobar" , "bazonk": return true
}
return false
}
s1na
force-pushed
the
config-ignore-deprecated
branch
from
0dc0c04 to
b6d2a54
Compare
holiman
reviewed
Jun 29, 2021
cmd/geth/config.go
Outdated
| return nil | ||
| } else { | ||
| link := "" | ||
| fmt.Printf("hereee %v %s\n", rt.String(), field) |
There was a problem hiding this comment.
Once this is gone, I think we can merge this, and then update #23118 to actually make use of this feature, and get that one in aswell
There was a problem hiding this comment.
Ops :) sorry will try to be more careful next time
s1na
force-pushed
the
config-ignore-deprecated
branch
from
b6d2a54 to
b27b85a
Compare
holiman
reviewed
Jun 30, 2021
Co-authored-by: Martin Holst Swende <martin@swende.se>
s1na
force-pushed
the
config-ignore-deprecated
branch
from
332b282 to
5e76b19
Compare
sidhujag
pushed a commit
to sidhujag/go-ethereum
that referenced
this pull request
Jun 30, 2021
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up as part of #23111 where we want to remove some noop flags. However, removing their respective config fields causes all existing toml config files to break.
It introduces a way to gracefully deprecate config fields. The map
deprecatedConfigshould be populated by keys likeethconfig.Config.EVMInterpreter.