Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethclient, internal/ethapi: allow eth_call with overrides #23129

Closed

Conversation

attente
Copy link

@attente attente commented Jun 29, 2021

This publishes the previously internal ethapi.StateOverrides type as well as adds the methods CallContractWithOverrides and
PendingCallContractWithOverrides to ethclient.Client.

#22197

This publishes the previously internal ethapi.StateOverrides type as
well as adds the methods CallContractWithOverrides and
PendingCallContractWithOverrides to ethclient.Client.

ethereum#22197
@attente attente force-pushed the ethclient-call-with-overrides branch from 521ed66 to 0be7ed6 Compare June 29, 2021 17:58
@MariusVanDerWijden
Copy link
Member

Hey @attente thank you for your contribution.
The overrides are unfortunately geth specific and ethclient should only contain functionality that is standardized between all clients. This is why we decided to put the eth_call with overrides into a new package called gethclient.
The PR for that is here: #22977
Sorry!

@attente
Copy link
Author

attente commented Jun 29, 2021

Ah, thank you for the explanation, makes perfect sense.

@attente attente closed this Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants