core/types: remove LogForStorage type #23173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the RLP encoding simply contains the first three fields of Log, we can avoid creating a temporary struct for encoding.
sidhujag
pushed a commit
to sidhujag/go-ethereum
that referenced
this pull request
Jul 10, 2021
The encoding of Log and LogForStorage is exactly the same now. After tracking it down it seems like ethereum#17106 changed the storage schema of logs to be the same as the consensus encoding. Support for the legacy format was dropped in ethereum#22852 and if I'm not wrong there's no reason anymore to have these two equivalent types. Since the RLP encoding simply contains the first three fields of Log, we can also avoid creating a temporary struct for encoding/decoding, and use the rlp:"-" tag in Log instead. Note: this is an API change in core/types. We decided it's OK to make this change because LogForStorage is an implementation detail of go-ethereum and the type has zero uses outside of package core/types. Co-authored-by: Felix Lange <fjl@twurst.com>
rjl493456442
added a commit
to rjl493456442/go-ethereum
that referenced
this pull request
Jul 22, 2021
This reverts commit 7522642.
sidhujag
pushed a commit
to sidhujag/go-ethereum
that referenced
this pull request
Jul 28, 2021
* Revert "core/types: go generate (ethereum#23177)" This reverts commit 00b922f. * Revert "core/types: remove LogForStorage type (ethereum#23173)" This reverts commit 7522642. * Revert "core/types: remove support for legacy receipt/log storage encoding (ethereum#22852)" This reverts commit 643fd0e.
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
The encoding of Log and LogForStorage is exactly the same now. After tracking it down it seems like ethereum#17106 changed the storage schema of logs to be the same as the consensus encoding. Support for the legacy format was dropped in ethereum#22852 and if I'm not wrong there's no reason anymore to have these two equivalent types. Since the RLP encoding simply contains the first three fields of Log, we can also avoid creating a temporary struct for encoding/decoding, and use the rlp:"-" tag in Log instead. Note: this is an API change in core/types. We decided it's OK to make this change because LogForStorage is an implementation detail of go-ethereum and the type has zero uses outside of package core/types. Co-authored-by: Felix Lange <fjl@twurst.com>
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
* Revert "core/types: go generate (ethereum#23177)" This reverts commit 00b922f. * Revert "core/types: remove LogForStorage type (ethereum#23173)" This reverts commit 7522642. * Revert "core/types: remove support for legacy receipt/log storage encoding (ethereum#22852)" This reverts commit 643fd0e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Martin noticed that the encoding of
LogandLogForStorageis exactly the same now. After tracking it down it seems like #17106 changed the storage schema of logs to be simply the encoding of[Address, Topics, Data], which is equivalent to the encoding ofLog(orrlpLog). Support for the legacy format was dropped in #22852 and if I'm not wrong there's no reason anymore to have these two equivalent types.Switching to this branch on a running node didn't seem to create a problem, but I'm not sure what to look for.
Note: this change includes an API change in
core/types