Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd, core, eth, miner: deprecate miner.gastarget flag #23213

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

rjl493456442
Copy link
Member

Fixes #23170

This PR simplifies the gas adjustment mechanism a bit and also drop the miner.gastarget flag support.
Note the CLI flag(--miner.gastarget) and the config field(miner.gasFloor) are still kept for backward compatibility.

@holiman
Copy link
Contributor

holiman commented Aug 2, 2021

So, if 1559 is not active, how will the 'simplified' algorithm behave? Previously, it decayed until the floor, unless the usage was above certain threshold, in which case it increased up to a max. The simplified form here -- I guess it just always targets the upper bound?

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop miner.gasTarget
3 participants