core/state/snapshot: clarify comment #23305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerchambers
requested review from
holiman,
karalabe and
rjl493456442
as code owners
holiman
reviewed
Jul 30, 2021
core/state/snapshot/snapshot.go
Outdated
| // and will be reconstructed from scratch based on the tries in the key-value | ||
| // store, on a background thread. If the memory layers from the journal is not | ||
| // continuous with disk layer or the journal is missing, all diffs will be discarded | ||
| // iff it's in "recovery" mode, otherwise rebuild is mandatory. | ||
| // if it's in "recovery" mode, otherwise rebuild is mandatory. |
There was a problem hiding this comment.
iff usually means if and only if. Not sure if that's the case here, but probably.
Funny, because it's the second time in a short span of time that someone has tried to fix this word :)
There was a problem hiding this comment.
you learn something new every day. thanks!
iff seems right. amended.
|
The comment is outdated. The stale/wrong snapshot won't be deleted but be reused during the rebuilding. |
So.. what should the comment say, exactly? |
fjl
changed the title
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
…23305) Co-authored-by: Tyler Chambers <me@tylerchambers.net> Co-authored-by: Felix Lange <fjl@twurst.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix to clarify what is deleted.
Fixes: #23298