eth, internal/ethapi: make RPC block miner field show block sealer correctly #23312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Header()) eth_getBlockByNumber eth_getBlockByHash
rjl493456442
reviewed
Aug 2, 2021
holiman
approved these changes
Aug 2, 2021
|
@holiman Can this pr be added to 1.10.7 |
holiman
changed the title
holiman
changed the title
sidhujag
pushed a commit
to sidhujag/go-ethereum
that referenced
this pull request
Aug 18, 2021
…rrectly (ethereum#23312) Makes the RPC block return the POA sealer for clique blocks on the 'miner' field (was previously zeroes)
|
This change breaks client side block hash calculation. |
github-actions bot
pushed a commit
to syuan100/go-ethereum
that referenced
this pull request
Aug 26, 2021
…ealer correctly (ethereum#23312)" (ethereum#23466) This reverts commit 57feabe.
sidhujag
pushed a commit
to sidhujag/go-ethereum
that referenced
this pull request
Aug 26, 2021
…ealer correctly (ethereum#23312)" (ethereum#23466) This reverts commit 57feabe.
@realdave our tests show that when using the go-ethereum go API, the returned block hash is wrong even on |
tclemos
added a commit
to hermeznetwork/go-ethereum
that referenced
this pull request
Aug 27, 2021
…ealer correctly (ethereum#23312)" This reverts commit 57feabe.
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
…rrectly (ethereum#23312) Makes the RPC block return the POA sealer for clique blocks on the 'miner' field (was previously zeroes)
AusIV
pushed a commit
to NoteGio/go-ethereum
that referenced
this pull request
Oct 25, 2021
…ealer correctly (ethereum#23312)" This reverts commit 57feabe.
yongjun925
pushed a commit
to DODOEX/go-ethereum
that referenced
this pull request
Dec 3, 2022
…ealer correctly (ethereum#23312)" (ethereum#23466) This reverts commit 57feabe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the poa consensus mechanism is used, the miner of each block will be 0x0000000000000000000000000000000000000000, modify the author method of returning to the engine.
RPC API:The miner returned by Block is consensus.Engine.Author(block.Header())
Also, implemented tests for:
eth_getBlockByNumber eth_getBlockByHash