Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/ethapi: add back missing check for maxfee < maxPriorityFee #23384

Merged
merged 1 commit into from
Aug 12, 2021
Merged

internal/ethapi: add back missing check for maxfee < maxPriorityFee #23384

merged 1 commit into from
Aug 12, 2021

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Aug 12, 2021 •
edited
Loading

In https://github.com/ethereum/go-ethereum/pull/23274/files#diff-4a9c1433c7c79c50cb72fd743c896f7bf5a976f46ccbb5fae83f5c46b2465db9R103, a check got lost. When the user/caller supplies both maxFee and maxPriorityFee, we still should verify that they are valid.

karalabe
karalabe approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe added this to the 1.10.7 milestone Aug 12, 2021
@karalabe karalabe merged commit 2a451f9 into ethereum:master Aug 12, 2021
@gzliudan gzliudan mentioned this pull request May 17, 2024
Open
19 tasks
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jul 5, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
05f225c 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jul 26, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
b577172 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 1, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
a471ac6 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 11, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
121b9ea 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
1bd7103 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
b45b5c6 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
abff3c1 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
6137cfc 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
7a47499 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 19, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
38a7f4c 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 21, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
bce143a 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 22, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
06b5ce8 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 23, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
53854ef 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 24, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
378381e 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 25, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
9c4343f 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 25, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
0e2e045 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
53c5fca 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
02e3220 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
34cd898 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 2, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
9464490 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 6, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
954d06e 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
f44785a 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
eeb0092 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
a6d2dd0 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
5e8272e 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
ac77036 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
d6f76e7 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
bc30395 
…thereum#23384)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
internal/ethapi: add back missing check for maxfee < maxPriorityFee (e…
d8e9549 
…thereum#23384)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.7
Development

Successfully merging this pull request may close these issues.
2 participants
@holiman @karalabe