accounts/external: handle 0 chainid as not-set for the Clef API #23394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
reviewed
Aug 13, 2021
accounts/external/backend.go
Outdated
| } | ||
| // We should request the default chain id that we're operating with | ||
| // (the chain we're executing on) | ||
| if chainID != nil { | ||
| if chainID != nil && chainID.BitLen() > 0 { |
There was a problem hiding this comment.
btw, the canonical zero check we use everywhere is int.Sign() == 0.
fjl
reviewed
Aug 13, 2021
accounts/external/backend.go
Outdated
| args.ChainID = (*hexutil.Big)(chainID) | ||
| } | ||
| if tx.Type() != types.LegacyTxType { | ||
| // However, if the user asked for a particular chain id, then we should | ||
| // use that instead. | ||
| if tx.ChainId() != nil { | ||
| if tx.ChainId() != nil && tx.ChainId().BitLen() > 0 { |
There was a problem hiding this comment.
Here, tx.ChainId can never be nil.
karalabe
force-pushed
the
fix-clef-0-chainid
branch
from
7d89fe2
to
365197d
Compare
holiman
reviewed
Aug 13, 2021
| args.ChainID = (*hexutil.Big)(chainID) | ||
| } | ||
| if tx.Type() != types.LegacyTxType { | ||
| // However, if the user asked for a particular chain id, then we should | ||
| // use that instead. | ||
| if tx.ChainId() != nil { | ||
| if tx.ChainId().Sign() != 0 { |
There was a problem hiding this comment.
Don't we need a nil-check here?
There was a problem hiding this comment.
ChainId() cannot return nil for non-legacy transactions.
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
…reum#23394) * accounts/external: handle 0 chainid as not-set for the Clef API * accounts/external: document SignTx Co-authored-by: Felix Lange <fjl@twurst.com>
This was referenced Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.