Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth/tracers: fix callTracer fault handling #23667

Merged
merged 2 commits into from
Oct 1, 2021
Merged

eth/tracers: fix callTracer fault handling #23667

merged 2 commits into from
Oct 1, 2021

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Sep 30, 2021 •
edited
Loading

Fixes #23660

The idea for this fix is that we don't need to handle fault at all. Errors will be caught by EVM and passed to exit anyway. Only problem was that exit wasn't being invoked after a fault happened.

Edit: I'll also fix the indentation issues before the PR is merged.

@s1na
Copy link
Contributor Author

s1na commented Sep 30, 2021

When comparing new vs legacy results for this PR I noticed a difference in output value. The following is a diff for tx https://etherscan.io/tx/0xae924257680a3ac49c18532a12c6bcf396cf6ba8cb89c76b10b64b0bf647dc10

https://gist.github.com/s1na/984bead325e2066c2885f9fbbaf029bf

@fjl fjl added this to the 1.10.10 milestone Sep 30, 2021
@s1na
Copy link
Contributor Author

s1na commented Sep 30, 2021

My best guess re the output difference is that the specified retSize for the CALL opcode is smaller than the byte array that interpreter returns.

@holiman
Copy link
Contributor

holiman commented Sep 30, 2021

My best guess re the output difference is that the specified retSize for the CALL opcode is smaller than the byte array that interpreter returns.

This is correct

@holiman
Copy link
Contributor

holiman commented Sep 30, 2021

The calls in diff 1 uses an out offset, out size of 0,0, but the call/delegatecalls actually return data. So it's correct behaviour by the tracer to show that data.
In these traces, the contract actually checks RETURNDATASIZE immediately after the call, and does use the output data. It's simply a more modern way of doing calls, and the new tracer correctly provides output where the old tracer did not.

holiman
holiman approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s1na
Copy link
Contributor Author

s1na commented Sep 30, 2021

Fixed the indentation too.

@holiman holiman merged commit b522f5e into ethereum:master Oct 1, 2021
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Oct 1, 2021
@s1na
eth/tracers: fix callTracer fault handling (ethereum#23667)
90b12d4 
* eth/tracers: fix calltracer fault handling

* eth/tracers: fix calltracer indentation
@s1na s1na deleted the fix/call-tracer-fault branch October 3, 2021 11:55
@s1na s1na mentioned this pull request Oct 6, 2021
Closed
@holiman holiman mentioned this pull request Oct 11, 2021
Closed
maoueh pushed a commit to streamingfast/go-ethereum that referenced this pull request Jan 31, 2022
@jsvisa @holiman
@MariusVanDerWijden @s1na @karalabe
[R4R]Feature/backport geth native trace (ethereum#581)
50ad4e3 
* eth/tracers: implement debug.intermediateRoots (ethereum#23594)

This PR implements a new debug method, which I've talked briefly about to some other client developers. It allows the caller to obtain the intermediate state roots for a block (which might be either a canon block or a 'bad' block).
Signed-off-by: wenbiao <delweng@gmail.com>

* core, rpc: disable memory output by default in traces (ethereum#23558)

* core: cmd: invert disableMemory

* core: fix missed inversion

* cmd/evm: preserve Flags but change default value

* Apply suggestions from code review

Co-authored-by: Martin Holst Swende <martin@swende.se>

Co-authored-by: Martin Holst Swende <martin@swende.se>
Signed-off-by: wenbiao <delweng@gmail.com>

* eth/tracers: abort evm execution when trace is aborted (ethereum#23580)

Signed-off-by: wenbiao <delweng@gmail.com>

* eth/tracers: avoid unsyncronized mutations on trie database (ethereum#23632)

This PR fixes an issue in traceChain, where the statedb Commit operation was performed asynchronously with dereference-operations agains the underlying trie.Database instance. Due to how the reference counting works within the trie database (where parent count is recursively updated when new parents are added), doing dereferencing in the middle of Commit can cause the refcount to become wrong, leading to an inconsistent state. 

This was fixed by doing Commit/Deref from the same routine.  
Signed-off-by: wenbiao <delweng@gmail.com>

* core,eth: call frame tracing (ethereum#23087)

This change introduces 2 new optional methods; `enter()` and `exit()` for js tracers, and makes `step()` optiona. The two new methods are invoked when entering and exiting a call frame (but not invoked for the outermost scope, which has it's own methods). Currently these are the data fields passed to each of them:

    enter: type (opcode), from, to, input, gas, value
    exit: output, gasUsed, error

The PR also comes with a re-write of the callTracer. As a backup we keep the previous tracing script under the name `callTracerLegacy`. Behaviour of both tracers are equivalent for the most part, although there are some small differences (improvements), where the new tracer is more correct / has more information.

Signed-off-by: wenbiao <delweng@gmail.com>

* eth/tracers: re-write of 4byte tracer using enter/exit (ethereum#23622)

* eth/tracers: add re-write of 4byte tracer using enter/exit

* eth/tracers: fix 4byte indent
Signed-off-by: wenbiao <delweng@gmail.com>

* eth/tracers: tx.BaseFee not implemented

Signed-off-by: wenbiao <delweng@gmail.com>

* eth/tracers: do the JSON serialization via .js to capture C faults

Signed-off-by: wenbiao <delweng@gmail.com>

* eth/tracers: fix callTracer fault handling (ethereum#23667)

* eth/tracers: fix calltracer fault handling

* eth/tracers: fix calltracer indentation
Signed-off-by: wenbiao <delweng@gmail.com>

* eth/tracers: invoke enter/exit on 0-value calls to inex accounts (ethereum#23828)

Signed-off-by: wenbiao <delweng@gmail.com>

* eth: make traceChain avoid OOM on long-running tracing (ethereum#23736)

This PR changes long-running chain tracing, so that it at some points releases the memory trie db, and switch over to a fresh disk-backed trie.
Signed-off-by: wenbiao <delweng@gmail.com>

* eth/tracers: expose contextual infos (block hash, tx hash, tx index)

Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>

* eth/tracers: redefine Context

Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>

* eth/tracers: support for golang tracers + add golang callTracer (ethereum#23708)

* eth/tracers: add basic native loader

* eth/tracers: add GetResult to tracer interface

* eth/tracers: add native call tracer

* eth/tracers: fix call tracer json result

* eth/tracers: minor fix

* eth/tracers: fix

* eth/tracers: fix benchTracer

* eth/tracers: test native call tracer

* eth/tracers: fix

* eth/tracers: rm extra make

Co-authored-by: Martin Holst Swende <martin@swende.se>

* eth/tracers: rm extra make

* eth/tracers: make callFrame private

* eth/tracers: clean-up and comments

* eth/tracers: add license

* eth/tracers: rework the model a bit

* eth/tracers: move tracecall tests to subpackage

* cmd/geth: load native tracers

* eth/tracers: minor fix

* eth/tracers: impl stop

* eth/tracers: add native noop tracer

* renamings

Co-authored-by: Martin Holst Swende <martin@swende.se>

* eth/tracers: more renamings

* eth/tracers: make jstracer non-exported, avoid cast

* eth/tracers, core/vm: rename vm.Tracer to vm.EVMLogger for clarity

* eth/tracers: minor comment fix

* eth/tracers/testing: lint nitpicks

* core,eth: cancel evm on nativecalltracer stop

* Revert "core,eth: cancel evm on nativecalltracer stop"

This reverts commit 01bb908.

* eth/tracers: linter nits

* eth/tracers: fix output on err

Co-authored-by: Martin Holst Swende <martin@swende.se>
Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>

* eth/tracers: make native calltracer default (ethereum#23867)

Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>

* eth/tracers: package restructuring (ethereum#23857)

* eth/tracers: restructure tracer package

* core/vm/runtime: load js tracers

* eth/tracers: mv bigint js code to own file

* eth/tracers: add method docs for native tracers

* eth/tracers: minor doc fix

* core,eth: cancel evm on nativecalltracer stop

* core/vm: fix failing test

Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com>
Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>

* eth/tracers: ethapi.TransactionArgs was not merged

Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>

* eth/tracers: fix the api_test with ErrInsufficientFunds to ErrInsufficientFundsForTransfer

Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>

* eth/tracers: check posa before statedb.Prepare in IntermiateRoots api

Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>

* eth/tracers: make js calltracer default, compatible with old version

Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>

* eth/tracers: fix the default callTrace name of callTracerJs

Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>

* Revert "eth/tracers: fix the default callTrace name of callTracerJs"

This reverts commit 62a3bc215d9f07e422a4c659289bb3ba4f9ed2fa.

Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>

* Revert "eth/tracers: make js calltracer default, compatible with old version"

This reverts commit 85ef42c0ea651f0b228d4209b1b2598b24e12f1f.

Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>

* eth/tracers: fix the variable race condition

Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>

Co-authored-by: Martin Holst Swende <martin@swende.se>
Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de>
Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com>
Co-authored-by: Péter Szilágyi <peterke@gmail.com>
Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com>
thaarok pushed a commit to thaarok/go-ethereum that referenced this pull request Sep 1, 2022
@s1na
eth/tracers: fix callTracer fault handling (ethereum#23667)
b59b8df 
* eth/tracers: fix calltracer fault handling

* eth/tracers: fix calltracer indentation
@thaarok thaarok mentioned this pull request Sep 1, 2022
Merged
uprendis added a commit to Fantom-foundation/go-ethereum that referenced this pull request Sep 1, 2022
@uprendis
Merge pull request #37 from hkalina/backport-23667
133089e 
eth/tracers: fix callTracer fault handling (ethereum#23667)
@a26nine a26nine mentioned this pull request Oct 9, 2022
Closed
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
@s1na @zzyalbert
eth/tracers: fix callTracer fault handling (ethereum#23667)
582e1ee 
* eth/tracers: fix calltracer fault handling

* eth/tracers: fix calltracer indentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

@karalabe karalabe Awaiting requested review from karalabe

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.10
Development

Successfully merging this pull request may close these issues.

Rinkeby network. Error: cannot read property 'calls' of undefined in server-side tracer function 'fault'
3 participants
@s1na @holiman @fjl