Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trie: more tests for StackTrie #23936

Merged
merged 1 commit into from
Nov 22, 2021
Merged

trie: more tests for StackTrie #23936

merged 1 commit into from
Nov 22, 2021

Conversation

chfast
Copy link
Member

@chfast chfast commented Nov 19, 2021

I used StackTrie to implement very basic Trie in C++ (only insert() and hash(), no database). There are unit tests I used to compare implementations.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman added this to the 1.10.13 milestone Nov 22, 2021
@holiman holiman changed the title tests: add reference for Trie (StackTrie) trie: more tests for StackTrie Nov 22, 2021
@holiman holiman merged commit 5d4bcbc into ethereum:master Nov 22, 2021
@chfast chfast deleted the trie_tests branch November 22, 2021 16:24
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Nov 23, 2021
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants