core/vm, core/state/snapshot: remove unused code #23956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
reviewed
Nov 23, 2021
| @@ -30,95 +30,50 @@ import ( | |||
| func TestWipe(t *testing.T) { | |||
There was a problem hiding this comment.
Any particular reason for removing the storage slot entries from this test?
There was a problem hiding this comment.
The scope of things being tested is different. Previously, the test tested more thoroughly the snapshot wiping. Since we removed the wiper, the only thing being tested is the wipeKeyRange. For wipeKeyRange, I felt that the only parts of interest were longer keys and shorter keys.
I don't think the test becomes any better just because we test on one set of 33-byte keys and one set of 65-byte keys.
I mean, we could even remove the whole notion of accounts/storage from this test, and just use blob data.
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Nov 25, 2021
* core/state/snapshot: remove wiper functionality * core/vm: remove unused 'unofficial' opcodes
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
* core/state/snapshot: remove wiper functionality * core/vm: remove unused 'unofficial' opcodes
13 tasks
19 tasks
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Mar 1, 2024
* core/state/snapshot: remove wiper functionality * core/vm: remove unused 'unofficial' opcodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the 'wiper', which was used in an early version of snap sync to clean out snap data. It was deprecated since we figured out how to use the mostly-correct-but-partially-corrupt snapshot data without wiping it fully.
This PR also removes some "unofficial opcodes used for parsing", which, actually, aren't used for parsing.