Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth: manually convert errors to strings on the trace API (json cannot) #2398

Merged
merged 1 commit into from
Mar 31, 2016

Conversation

karalabe
Copy link
Member

The json package will marshal an error to {} per golang/go#10748 and http://play.golang.org/p/RAKJbcQpLX . This PR manually converts trace errors to strings before returning them.

@robotally
Copy link

Vote Count Reviewers
👍 1 @obscuren
👎 0

Updated: Thu Mar 31 14:54:41 UTC 2016

@obscuren
Copy link
Contributor

👍

@codecov-io
Copy link

Current coverage is 50.77%

Merging #2398 into develop will not affect coverage as of 0d0fd67

Powered by Codecov. Updated on successful CI builds.

@karalabe karalabe merged commit f115f07 into ethereum:develop Mar 31, 2016
@obscuren obscuren removed the review label Mar 31, 2016
maoueh pushed a commit to streamingfast/go-ethereum that referenced this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants