Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/catalyst: implement kintsugi spec v1.0.0-alpha.4 #23984

Merged
merged 5 commits into from
Dec 3, 2021

Conversation

MariusVanDerWijden
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden commented Nov 26, 2021

This PR implements the new kintsugi specification which can be found here: https://github.com/ethereum/execution-apis/blob/v1.0.0-alpha.4/src/engine/specification.md

eth/catalyst/api.go Outdated Show resolved Hide resolved
eth/catalyst/api.go Show resolved Hide resolved
eth/catalyst/api.go Outdated Show resolved Hide resolved
eth/catalyst/api.go Outdated Show resolved Hide resolved
@MariusVanDerWijden MariusVanDerWijden changed the title eth/catalyst: implement kintsugi spec v1.0.0-alpha.3 eth/catalyst: implement kintsugi spec v1.0.0-alpha.4 Nov 30, 2021
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, otherwise LGTM

eth/catalyst/api.go Outdated Show resolved Hide resolved
eth/catalyst/api.go Show resolved Hide resolved
eth/catalyst/api.go Outdated Show resolved Hide resolved
eth/catalyst/api.go Outdated Show resolved Hide resolved
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman added this to the 1.10.14 milestone Dec 3, 2021
@holiman holiman merged commit 93f196c into ethereum:master Dec 3, 2021
JacekGlen pushed a commit to JacekGlen/go-ethereum that referenced this pull request May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants