Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/solidity/contracts: fix typo in OpCodes.sol #24123

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

eltociear
Copy link
Contributor

begining -> beginning

begining -> beginning
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@holiman
Copy link
Contributor

holiman commented Dec 17, 2021

Personally, I'd rather revert the whole #19283. We're not using it, and I don't see any road ahead to start using it -- it's very unclear, to me, how it would be used

@fjl fjl changed the title tests: fix typo in OpCodes.sol tests/solidity/contracts: fix typo in OpCodes.sol Dec 17, 2021
@fjl fjl merged commit f5f5c08 into ethereum:master Dec 17, 2021
@fjl fjl added this to the 1.10.14 milestone Dec 17, 2021
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Dec 19, 2021
JacekGlen pushed a commit to JacekGlen/go-ethereum that referenced this pull request May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants