core, miner, rpc, eth: fix goroutine leaks in tests #24211
Conversation
charlesxsh
requested review from
fjl,
gballet,
holiman,
karalabe and
rjl493456442
as code owners
charlesxsh
force-pushed
the
gfuzzissues
branch
from
485e31b
to
816864c
Compare
charlesxsh
force-pushed
the
gfuzzissues
branch
from
816864c
to
7855d61
Compare
No problem! |
core/blockchain.go
Outdated
| num := number - offset | ||
| recent := bc.GetBlockByNumber(num) | ||
| if recent == nil { | ||
| log.Error("Failed to get block", num) |
There was a problem hiding this comment.
| log.Error("Failed to get block", num) | |
| log.Error("Failed to get block", "number", num) |
core/blockchain.go
Outdated
| num := number - offset | ||
| recent := bc.GetBlockByNumber(num) | ||
| if recent == nil { | ||
| log.Error("Failed to get block", num) | ||
| continue | ||
| } |
There was a problem hiding this comment.
We'd rather revert this -- is this path triggered by the tests?
Also, the log format is wrong, would need to be log.Error("Failed to get block", "num", num)
There was a problem hiding this comment.
As far as I could tell, the tests didn't trigger this path, so I have reverted this change. If this happens, it indicates that something is seriously wrong, either our blockchain is corrupt, or the database is closed.
| @@ -1779,6 +1779,7 @@ func testRepair(t *testing.T, tt *rewindTest, snapshots bool) { | |||
| SnapshotLimit: 0, // Disable snapshot by default | |||
| } | |||
| ) | |||
| defer engine.Close() | |||
There was a problem hiding this comment.
Is it necessary to close the FullFaker ethash engine? There is nothing to do in the Close function
There was a problem hiding this comment.
You're right it can't be necessary, but doing it is more correct, so I'd rather just keep it htere
holiman
changed the title
* fix blocking and non-blocking issues * core: revert change in blockchain.go Co-authored-by: Martin Holst Swende <martin@swende.se>
* fix blocking and non-blocking issues * core: revert change in blockchain.go Co-authored-by: Martin Holst Swende <martin@swende.se>
This PR fixes following issues:
testRepair goroutine leak
TestRegisterHandler_Successful goroutine leak
TestStartStopMiner
TestClientReconnect
TestMinerDownloaderFirstFails
same as 3
TestBuildSchema
Node created is missing close.
TestMinerSetEtherbase
same as 3
8
TestCloseMiner
same as 3
9
testSequentialAnnouncements
10
TestEmptyBlockShortCircuit
if completing timeout happened first, sending operation of completing will be blocked
11
TestNatto
12
testRegenerateMiningBlock
if new task timeout happened first, sending operation on taskCh will be blocked
13
TestSignTx
api.List might possibly return both nil
14
TestLightInvalidNumberAnnouncement
if announce timeout happened first, sending operation might be blocked